openlmi-reviews Digest, Vol 1, Issue 3

openlmi-reviews-request at lists.fedorahosted.org openlmi-reviews-request at lists.fedorahosted.org
Thu May 30 08:06:59 UTC 2013


Send openlmi-reviews mailing list submissions to
	openlmi-reviews at lists.fedorahosted.org

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
	openlmi-reviews-request at lists.fedorahosted.org

You can reach the person managing the list at
	openlmi-reviews-owner at lists.fedorahosted.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."


Today's Topics:

   1. Re: Review Request 418: openlmi-networking [1/4] Implement
      NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
      (Radek Novacek)
   2. Re: Review Request 419: openlmi-networking [2/4] Implement
      some more	properties of defined classes (Radek Novacek)
   3. Re: Review Request 420: openlmi-networking [3/4] Rename
      AddStaticIPRoute to LMI_AddStaticIPRoute (Radek Novacek)
   4. Re: Review Request 421: openlmi-networking [4/4] Fix
      documentation to	use new settings API (Radek Novacek)
   5. Re: Review Request 417: Account [1/1] Account: Correctly
      handle empty	fields in shadow file (Roman Rakus)


----------------------------------------------------------------------

Message: 1
Date: Thu, 30 May 2013 08:02:59 -0000
From: Radek Novacek <reviewboard at gallagherhome.com>
To: "Jan Safranek" <jsafrane at redhat.com>,	"OpenLMI Developers"
	<openlmi-reviews at lists.fedorahosted.org>,	"Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 418: openlmi-networking [1/4] Implement
	NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
Message-ID:
	<20130530080259.11235.95270 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/418/
-----------------------------------------------------------

(Updated May 30, 2013, 10:02 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort


Diffs
-----

  mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 
  src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603 
  src/port.h 8558a4e2752f3f12972514d9bae803d03949a201 
  src/port.c 3d69058c197142bb257d3f6ed6706c44f67b1f02 
  src/port_nm.c 70f5453fda21bf886451c460f15795588caf9fc4 
  src/port_private.h fc27956d8d475df355072751d007a3b0dc91534c 

Diff: http://reviewboard-openlmi.rhcloud.com/r/418/diff/


Testing
-------


Thanks,

Radek Novacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/245f453c/attachment-0001.html>

------------------------------

Message: 2
Date: Thu, 30 May 2013 08:03:05 -0000
From: Radek Novacek <reviewboard at gallagherhome.com>
To: "Jan Safranek" <jsafrane at redhat.com>,	"OpenLMI Developers"
	<openlmi-reviews at lists.fedorahosted.org>,	"Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 419: openlmi-networking [2/4] Implement
	some more	properties of defined classes
Message-ID:
	<20130530080305.11235.19161 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/419/
-----------------------------------------------------------

(Updated May 30, 2013, 10:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Implement some more properties of defined classes


Diffs
-----

  mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 
  src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603 
  src/LMI_IPNetworkConnectionCapabilitiesProvider.c cd5fac1701378399b5a06634ab46aad1a1b91153 
  src/LMI_IPNetworkConnectionProvider.c a312e5571db0d7e8867f768b81365708b53d6657 
  src/LMI_IPVersionSettingDataProvider.c 79ab767531e768b767c5316b91542d270d9b1918 

Diff: http://reviewboard-openlmi.rhcloud.com/r/419/diff/


Testing
-------


Thanks,

Radek Novacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/3b7182a2/attachment-0001.html>

------------------------------

Message: 3
Date: Thu, 30 May 2013 08:03:11 -0000
From: Radek Novacek <reviewboard at gallagherhome.com>
To: "Jan Safranek" <jsafrane at redhat.com>,	"OpenLMI Developers"
	<openlmi-reviews at lists.fedorahosted.org>,	"Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 420: openlmi-networking [3/4] Rename
	AddStaticIPRoute to LMI_AddStaticIPRoute
Message-ID:
	<20130530080311.11235.36444 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/420/
-----------------------------------------------------------

(Updated May 30, 2013, 10:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Rename AddStaticIPRoute to LMI_AddStaticIPRoute

Add the LMI_ prefix to emphasize that it's a custom class.


Diffs
-----

  mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 
  src/LMI_IPAssignmentSettingDataProvider.c 538123c0a45deace760eca742acda80028c0d8ae 
  test/test_create_destroy_connection.py 39dc2bec3c3bc14bb8833fd9c888d8b3e8caa8a5 

Diff: http://reviewboard-openlmi.rhcloud.com/r/420/diff/


Testing
-------


Thanks,

Radek Novacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/0f20c93d/attachment-0001.html>

------------------------------

Message: 4
Date: Thu, 30 May 2013 08:03:11 -0000
From: Radek Novacek <reviewboard at gallagherhome.com>
To: "Jan Safranek" <jsafrane at redhat.com>,	"OpenLMI Developers"
	<openlmi-reviews at lists.fedorahosted.org>,	"Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 421: openlmi-networking [4/4] Fix
	documentation to	use new settings API
Message-ID:
	<20130530080311.11233.89724 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/421/
-----------------------------------------------------------

(Updated May 30, 2013, 10:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Fix documentation to use new settings API


Diffs
-----

  doc/admin/usage-generic.rst aa27e6edb3501f2b12d0235638381f365b2bdef0 

Diff: http://reviewboard-openlmi.rhcloud.com/r/421/diff/


Testing
-------


Thanks,

Radek Novacek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/61f44128/attachment-0001.html>

------------------------------

Message: 5
Date: Thu, 30 May 2013 08:06:56 -0000
From: Roman Rakus <reviewboard at gallagherhome.com>
To: "Radek Novacek" <rnovacek at redhat.com>,	"OpenLMI Developers"
	<openlmi-reviews at lists.fedorahosted.org>,	"Stephen Gallagher"
	<sgallagh at fedoraproject.org>,	"Roman Rakus" <rrakus at redhat.com>
Subject: Re: Review Request 417: Account [1/1] Account: Correctly
	handle empty	fields in shadow file
Message-ID:
	<20130530080656.11233.37642 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/
-----------------------------------------------------------

(Updated May 30, 2013, 8:06 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Correctly handle empty fields in shadow file

libuser returns -1 for empty fields. Handle the -1 on missing places.

Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of range"

Signed-off-by: Roman Rakus <rrakus at redhat.com>


Diffs (updated)
-----

  src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455 
  src/account/macros.h 513d4723c29dcef20753130b037eb99db5a66a30 

Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/


Testing
-------


Thanks,

Roman Rakus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/bf2093a2/attachment.html>

------------------------------

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews


End of openlmi-reviews Digest, Vol 1, Issue 3
*********************************************


More information about the openlmi-devel mailing list