openlmi-reviews Digest, Vol 1, Issue 2

openlmi-reviews-request at lists.fedorahosted.org openlmi-reviews-request at lists.fedorahosted.org
Thu May 30 08:00:03 UTC 2013


Send openlmi-reviews mailing list submissions to
	openlmi-reviews at lists.fedorahosted.org

To subscribe or unsubscribe via the World Wide Web, visit
	https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
	openlmi-reviews-request at lists.fedorahosted.org

You can reach the person managing the list at
	openlmi-reviews-owner at lists.fedorahosted.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."


Today's Topics:

   1. Re: Review Request 419: openlmi-networking [2/4] Implement
      some more	properties of defined classes (Jan Safranek)
   2. Re: Review Request 420: openlmi-networking [3/4] Rename
      AddStaticIPRoute to LMI_AddStaticIPRoute (Jan Safranek)
   3. Re: Review Request 421: openlmi-networking [4/4] Fix
      documentation to	use new settings API (Jan Safranek)
   4. Re: Review Request 417: Account [1/1] Account: Correctly
      handle empty	fields in shadow file (Roman Rakus)


----------------------------------------------------------------------

Message: 1
Date: Thu, 30 May 2013 07:58:42 -0000
From: Jan Safranek <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Jan Safranek" <jsafrane at redhat.com>, "Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 419: openlmi-networking [2/4] Implement
	some more	properties of defined classes
Message-ID:
	<20130530075842.11235.31654 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/419/#review502
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/419/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 12:55 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Implement some more properties of defined classes
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 
>   src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603 
>   src/LMI_IPNetworkConnectionCapabilitiesProvider.c cd5fac1701378399b5a06634ab46aad1a1b91153 
>   src/LMI_IPNetworkConnectionProvider.c a312e5571db0d7e8867f768b81365708b53d6657 
>   src/LMI_IPVersionSettingDataProvider.c 79ab767531e768b767c5316b91542d270d9b1918 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/419/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/d1587085/attachment-0001.html>

------------------------------

Message: 2
Date: Thu, 30 May 2013 07:59:02 -0000
From: Jan Safranek <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Jan Safranek" <jsafrane at redhat.com>, "Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 420: openlmi-networking [3/4] Rename
	AddStaticIPRoute to LMI_AddStaticIPRoute
Message-ID:
	<20130530075902.11235.48157 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/420/#review503
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/420/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 12:55 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Rename AddStaticIPRoute to LMI_AddStaticIPRoute
> 
> Add the LMI_ prefix to emphasize that it's a custom class.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88 
>   src/LMI_IPAssignmentSettingDataProvider.c 538123c0a45deace760eca742acda80028c0d8ae 
>   test/test_create_destroy_connection.py 39dc2bec3c3bc14bb8833fd9c888d8b3e8caa8a5 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/e582e93c/attachment-0001.html>

------------------------------

Message: 3
Date: Thu, 30 May 2013 07:59:41 -0000
From: Jan Safranek <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Jan Safranek" <jsafrane at redhat.com>, "Radek Novacek"
	<rnovacek at redhat.com>
Subject: Re: Review Request 421: openlmi-networking [4/4] Fix
	documentation to	use new settings API
Message-ID:
	<20130530075941.11233.66505 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/421/#review504
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/421/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 12:55 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Fix documentation to use new settings API
> 
> 
> Diffs
> -----
> 
>   doc/admin/usage-generic.rst aa27e6edb3501f2b12d0235638381f365b2bdef0 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/421/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/6d8985bc/attachment-0001.html>

------------------------------

Message: 4
Date: Thu, 30 May 2013 07:59:49 -0000
From: Roman Rakus <reviewboard at gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews at lists.fedorahosted.org>,
	"Stephen Gallagher" <sgallagh at fedoraproject.org>,	"Roman Rakus"
	<rrakus at redhat.com>
Subject: Re: Review Request 417: Account [1/1] Account: Correctly
	handle empty	fields in shadow file
Message-ID:
	<20130530075949.11233.56067 at ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"



> On May 29, 2013, 7:37 p.m., Stephen Gallagher wrote:
> > src/account/LMI_AccountProvider.c, lines 123-137
> > <http://reviewboard-openlmi.rhcloud.com/r/417/diff/1/?file=2484#file2484line123>
> >
> >     Could you create a macro definition for -1 instead of using magic numbers? That way it's clear what you're testing for. Something like
> >     
> >     #define SHADOW_VALUE_EMPTY -1

Good idea. Also added macro for 99999 value.


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/#review499
-----------------------------------------------------------


On May 28, 2013, 2:42 p.m., Roman Rakus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/417/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 2:42 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Account: Correctly handle empty fields in shadow file
> 
> libuser returns -1 for empty fields. Handle the -1 on missing places.
> 
> Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of range"
> 
> Signed-off-by: Roman Rakus <rrakus at redhat.com>
> 
> 
> Diffs
> -----
> 
>   src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Roman Rakus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-reviews/attachments/20130530/7d7dce2a/attachment.html>

------------------------------

_______________________________________________
openlmi-reviews mailing list
openlmi-reviews at lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews


End of openlmi-reviews Digest, Vol 1, Issue 2
*********************************************


More information about the openlmi-devel mailing list