Review Request 344: [openlmi-providers] Fix small memory leaks in fan provider

Radek Novacek reviewboard at gallagherhome.com
Mon May 20 14:33:45 UTC 2013



> On May 16, 2013, 10:41 a.m., Radek Novacek wrote:
> > src/fan/LMI_FanAssociatedSensorProvider.c, line 91
> > <http://reviewboard-openlmi.rhcloud.com/r/344/diff/1/?file=2229#file2229line91>
> >
> >     I've recently added LMI_ReturnInstance macro that returns boolean (false if instance can't be returned). Could you please use it here?
> >     
> >     https://reviewboard-openlmi.rhcloud.com/r/359/diff/#index_header

Taking back this issue, LMI_ReturnInstance chokes the status information which is wrong.


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/344/#review421
-----------------------------------------------------------


On May 13, 2013, 4:58 p.m., Stephen Gallagher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/344/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 4:58 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> Fix memory leaks
> 
> Fixes Coverity issues:
>  * 10153
>  * 10154
>  * 10155
> 
> 
> Diffs
> -----
> 
>   src/fan/LMI_FanAssociatedSensorProvider.c b462e83d5f5f353a0e09dfb8af80babe5b8f83a6 
>   src/fan/LMI_FanProvider.c 26af16ea3c119c4ea9fd8812e5b8cf9ed5007347 
>   src/fan/LMI_FanSensorProvider.c e63d266260db54b5a7b779722b6487f2f03d7776 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/344/diff/
> 
> 
> Testing
> -------
> 
> Compilation test only.
> 
> 
> Thanks,
> 
> Stephen Gallagher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130520/b5fbf018/attachment-0001.html>


More information about the openlmi-devel mailing list