Review Request 344: [openlmi-providers] Fix small memory leaks in fan provider
Radek Novacek
reviewboard at gallagherhome.com
Thu May 16 08:41:44 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/344/#review421
-----------------------------------------------------------
src/fan/LMI_FanAssociatedSensorProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/344/#comment274>
I've recently added LMI_ReturnInstance macro that returns boolean (false if instance can't be returned). Could you please use it here?
https://reviewboard-openlmi.rhcloud.com/r/359/diff/#index_header
- Radek Novacek
On May 13, 2013, 4:58 p.m., Stephen Gallagher wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/344/
> -----------------------------------------------------------
>
> (Updated May 13, 2013, 4:58 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Fix memory leaks
>
> Fixes Coverity issues:
> * 10153
> * 10154
> * 10155
>
>
> Diffs
> -----
>
> src/fan/LMI_FanAssociatedSensorProvider.c b462e83d5f5f353a0e09dfb8af80babe5b8f83a6
> src/fan/LMI_FanProvider.c 26af16ea3c119c4ea9fd8812e5b8cf9ed5007347
> src/fan/LMI_FanSensorProvider.c e63d266260db54b5a7b779722b6487f2f03d7776
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/344/diff/
>
>
> Testing
> -------
>
> Compilation test only.
>
>
> Thanks,
>
> Stephen Gallagher
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130516/c86fd921/attachment.html>
More information about the openlmi-devel
mailing list