Review Request 79: openlmi-networking [3/8] Use IPNetworkConnection instead LANEndpoint when creating connections

Radek Novacek reviewboard at gallagherhome.com
Fri Mar 29 07:20:34 UTC 2013



> On March 28, 2013, 4:47 p.m., Jan Safranek wrote:
> > src/LMI_IPConfigurationServiceProvider.c, line 626
> > <http://reviewboard-openlmi.rhcloud.com/r/79/diff/1/?file=430#file430line626>
> >
> >     ProtocolIFType->value != 2 would be more readable... but I'm not opening an issue for it.

This checks for other possibilities, like -1, 0, 4, 5... Only valid values are 1, 2 and 3.


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/79/#review79
-----------------------------------------------------------


On March 28, 2013, 3:07 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/79/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 3:07 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Use IPNetworkConnection instead LANEndpoint when creating connections
> 
> Using IPNetworkConnection is more consistent with other methods.
> LANEndpoint should be used just for hardware description and not for
> connection manipulation.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof 61a0bff26e0b879ea9c986449419686124898562 
>   src/LMI_IPConfigurationServiceProvider.c a98132789a36bed7837f9b23872eaeb84d5c2c8d 
>   test/test_bonding.py 64ad5c8908d8b30d04e4cddde74343cb97693a5d 
>   test/test_create_destroy_connection.py a68d32bc39cbd703884315e9fd594228ebc59522 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/79/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130329/84213c0a/attachment-0001.html>


More information about the openlmi-devel mailing list