<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-openlmi.rhcloud.com/r/79/">http://reviewboard-openlmi.rhcloud.com/r/79/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 28th, 2013, 4:47 p.m. CET, <b>Jan Safranek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://reviewboard-openlmi.rhcloud.com/r/79/diff/1/?file=430#file430line626" style="color: black; font-weight: bold; text-decoration: underline;">src/LMI_IPConfigurationServiceProvider.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KUint32 LMI_IPConfigurationService_CreateStaticSetting(</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">625</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">ProtocolIFType</span><span class="o">-></span><span class="n">value</span> <span class="o"><span class="hl">==</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">626</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">ProtocolIFType</span><span class="o">-></span><span class="n">value</span> <span class="o"><span class="hl"><</span></span><span class="hl"> </span><span class="mi"><span class="hl">1</span></span><span class="hl"> </span><span class="o"><span class="hl">||</span></span><span class="hl"> </span><span class="n"><span class="hl">ProtocolIFType</span></span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">value</span></span><span class="hl"> </span><span class="o"><span class="hl">></span></span><span class="hl"> </span><span class="mi"><span class="hl">3</span></span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ProtocolIFType->value != 2 would be more readable... but I'm not opening an issue for it.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This checks for other possibilities, like -1, 0, 4, 5... Only valid values are 1, 2 and 3.</pre>
<br />
<p>- Radek</p>
<br />
<p>On March 28th, 2013, 3:07 p.m. CET, Radek Novacek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for OpenLMI Developers.</div>
<div>By Radek Novacek.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 3:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use IPNetworkConnection instead LANEndpoint when creating connections
Using IPNetworkConnection is more consistent with other methods.
LANEndpoint should be used just for hardware description and not for
connection manipulation.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mof/LMI_Networking.mof <span style="color: grey">(61a0bff26e0b879ea9c986449419686124898562)</span></li>
<li>src/LMI_IPConfigurationServiceProvider.c <span style="color: grey">(a98132789a36bed7837f9b23872eaeb84d5c2c8d)</span></li>
<li>test/test_bonding.py <span style="color: grey">(64ad5c8908d8b30d04e4cddde74343cb97693a5d)</span></li>
<li>test/test_create_destroy_connection.py <span style="color: grey">(a68d32bc39cbd703884315e9fd594228ebc59522)</span></li>
</ul>
<p><a href="http://reviewboard-openlmi.rhcloud.com/r/79/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>