Patch review for OpenLMI

Stephen Gallagher sgallagh at redhat.com
Fri Mar 15 17:10:12 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/15/2013 12:40 PM, Jan Safranek wrote:
> On 03/14/2013 09:35 PM, Stephen Gallagher wrote:
>> There are two ways that you can submit a patch for review. The
>> most automated way is to install the RBTools package on Fedora or
>> EPEL and then use the 'post-review' binary.
> 
> I tried and I failed:
> 
> $ post-review -g -o
> --server=https://reviewboard-openlmi.rhcloud.com 
> --username=jsafrane
> 
> There was an error creating this review request.
> 
> The repository path 
> "git+ssh://jsafrane@git.fedorahosted.org/git/openlmi-storage.git"
> is not in the list of known repositories on the server.
> 
> 
> </cite>
> 
> I see some openlmi-storage in
> reviewboard-openlmi.rhcloud.com/r/new/, but it seems to expect
> different repo path.
> 
> Jan
> 

Yeah, what you want to do is add a .reviewboardrc file to the root of
the repo checkout containing:

REVIEWBOARD_URL = 'https://reviewboard-openlmi.rhcloud.com'
REPOSITORY = 'openlmi-storage'


If you had cloned the repository from the anonymous URL
(git://git.fedorahosted.org/git/openlmi-storage.git), post-review
would have been able to automatically figure out to which repo to
submit the patch. But since your checkout was using the committer URL,
you need to just tell Review Board explicitly which one to use for
this checkout.

If we decide to stick with Review Board in the future, we'll want to
just commit that .reviewboardrc to the repository so that it will Just
Work for anyone in the future.

Also, as you probably can figure out, you need to change the
REPOSITORY= line appropriately for the other git repos as well.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlFDVfQACgkQeiVVYja6o6OtQwCcCoGc6fiCTHjF1nPnGndPJLG5
r8kAoI95e+viXboW4oK+3eyec5kHGnBx
=FRFU
-----END PGP SIGNATURE-----


More information about the openlmi-devel mailing list