Review Request 244: openlmi-networking [1/6] Simplify creation of IPAssignmentSettingData
Radek Novacek
reviewboard at gallagherhome.com
Tue Apr 23 05:59:42 UTC 2013
> On April 22, 2013, 3:27 p.m., Jan Safranek wrote:
> > src/LMI_IPAssignmentSettingDataProvider.c, line 68
> > <http://reviewboard-openlmi.rhcloud.com/r/244/diff/1/?file=1350#file1350line68>
> >
> > You might save few CPU cycles by using some enum instead of string with class name & strcmp
> >
> > (remarks the one who writes providers in Python :)
I'll do it later, thanks for the tip.
- Radek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/244/#review274
-----------------------------------------------------------
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/244/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 2:41 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Simplify creation of IPAssignmentSettingData
>
> Use one common function to create instances of all following classes:
> * LMI_IPAssignmentSettingData
> * LMI_ExtendedStaticIPAssignmentSettingData
> * LMI_DHCPSettingData
>
>
> Diffs
> -----
>
> src/LMI_DHCPSettingDataProvider.c 6c3f2fc56d52395d6babe57ef3c1e350f188a157
> src/CMakeLists.txt f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e
> src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c17b93921cc035352be7e733760d34a03f29a30a
> src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46
> src/ipassignmentsettingdata.h PRE-CREATION
> src/ipassignmentsettingdata.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/244/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130423/74aef8fd/attachment.html>
More information about the openlmi-devel
mailing list