<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/244/">http://reviewboard-openlmi.rhcloud.com/r/244/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On April 22nd, 2013, 3:27 p.m. CEST, <b>Jan Safranek</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/244/diff/1/?file=1350#file1350line68" style="color: black; font-weight: bold; text-decoration: underline;">src/LMI_IPAssignmentSettingDataProvider.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static CMPIStatus LMI_IPAssignmentSettingDataEnumInstances(</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">Connection</span> <span class="o">*</span><span class="n">connection</span><span class="p">;</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            <span class="n">LMI_IPAssignmentSettingData_ClassName</span><span class="p">,</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You might save few CPU cycles by using some enum instead of string with class name &amp; strcmp

(remarks the one who writes providers in Python :)</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;ll do it later, thanks for the tip.</pre>
<br />




<p>- Radek</p>


<br />
<p>On April 19th, 2013, 2:41 p.m. CEST, Radek Novacek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Radek Novacek.</div>


<p style="color: grey;"><i>Updated April 19, 2013, 2:41 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Simplify creation of IPAssignmentSettingData

Use one common function to create instances of all following classes:
* LMI_IPAssignmentSettingData
* LMI_ExtendedStaticIPAssignmentSettingData
* LMI_DHCPSettingData
</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/LMI_DHCPSettingDataProvider.c <span style="color: grey">(6c3f2fc56d52395d6babe57ef3c1e350f188a157)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(f0f1ea7f22e85298f69074aa7ce6a9c6c26eb38e)</span></li>

 <li>src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c <span style="color: grey">(c17b93921cc035352be7e733760d34a03f29a30a)</span></li>

 <li>src/LMI_IPAssignmentSettingDataProvider.c <span style="color: grey">(96b70f67db210023e939dcfe2a20ba598802bc46)</span></li>

 <li>src/ipassignmentsettingdata.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/ipassignmentsettingdata.c <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/244/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>