Review Request 118: openlmi-software [2/7] added indication manager to openlmi.common
Michal Minar
reviewboard at gallagherhome.com
Thu Apr 11 16:13:13 UTC 2013
> On April 8, 2013, 10:42 a.m., Roman Rakus wrote:
> > src/python/openlmi/common/IndicationManager.py, line 100
> > <http://reviewboard-openlmi.rhcloud.com/r/118/diff/1/?file=658#file658line100>
> >
> > Please add a note that it is case insensitive.
re.I changed to full name: re.IGNORECASE
to make it more readable
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/118/#review114
-----------------------------------------------------------
On April 11, 2013, 4:12 p.m., Michal Minar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/118/
> -----------------------------------------------------------
>
> (Updated April 11, 2013, 4:12 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> added indication manager to openlmi.common
>
> IndicationManager python module is useful for many providers across
> OpenLMI project. That's why it's landing in openlmi.common subpackage
> from openlmi-storage. It supports checking for static filters
>
> IndicationManager allows to check and install static filters at broker
> at runtime
> - but it should be avoided
>
>
> Diffs
> -----
>
> src/software/openlmi/software/yumdb/jobmanager.py 872e81fecf030743d89d41d0436a2cb5cd1fb878
> mof/LMI_SoftwareIndicationFilters.mof PRE-CREATION
> src/python/openlmi/common/IndicationManager.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/118/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Minar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130411/a4f5bf31/attachment-0001.html>
More information about the openlmi-devel
mailing list