Review Request 118: openlmi-software [2/7] added indication manager to openlmi.common

Roman Rakus reviewboard at gallagherhome.com
Mon Apr 8 10:42:21 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/118/#review114
-----------------------------------------------------------



src/python/openlmi/common/IndicationManager.py
<http://reviewboard-openlmi.rhcloud.com/r/118/#comment62>

    Please add a note that it is case insensitive.


- Roman Rakus


On April 8, 2013, 10:06 a.m., Michal Minar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/118/
> -----------------------------------------------------------
> 
> (Updated April 8, 2013, 10:06 a.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-providers
> 
> 
> Description
> -------
> 
> added indication manager to openlmi.common
> 
> IndicationManager python module is useful for many providers across
> OpenLMI project. That's why it's landing in openlmi.common subpackage
> from openlmi-storage. It supports checking for static filters
> 
> IndicationManager allows to check and install static filters at broker
> at runtime
>  - but it should be avoided
> 
> 
> Diffs
> -----
> 
>   src/python/openlmi/common/IndicationManager.py PRE-CREATION 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/118/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Minar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130408/dadd4356/attachment.html>


More information about the openlmi-devel mailing list