Review Request 95: Unused devices: [3/5] Added checks to overwrite only unused devices.
Radek Novacek
reviewboard at gallagherhome.com
Fri Apr 5 13:23:23 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/#review105
-----------------------------------------------------------
src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/95/#comment60>
I think it would be much more readable to have comment like "Raise CIMError if device is used". Now it's not clear what will happen without looking at check_unused implementation.
- Radek Novacek
On April 4, 2013, 6:33 p.m., Jan Safranek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/95/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 6:33 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-storage
>
>
> Description
> -------
>
> Added checks to overwrite only unused devices.
>
>
> Diffs
> -----
>
> src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py 195a66e6cdc8f98e054aa3d6e7efb2306d721871
> src/openlmi/storage/LMI_FileSystemConfigurationService.py f8b76551652443e1c53e3b592a52a3c0bb740494
> src/openlmi/storage/LMI_StorageConfigurationService.py 0abd5099b6ebb707abf95bbc6bdbc64951f3128a
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jan Safranek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130405/d4a3affd/attachment.html>
More information about the openlmi-devel
mailing list