<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard-openlmi.rhcloud.com/r/95/">http://reviewboard-openlmi.rhcloud.com/r/95/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://reviewboard-openlmi.rhcloud.com/r/95/diff/1/?file=494#file494line81" style="color: black; font-weight: bold; text-decoration: underline;">src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def cim_method_setpartitionstyle(self, env, object_name,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="bp">self</span><span class="o">.</span><span class="n">storage</span><span class="o">.</span><span class="n">deviceDeps</span><span class="p">(</span><span class="n">device</span><span class="p">):</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">81</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c"># Check the device is unused</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think it would be much more readable to have comment like "Raise CIMError if device is used". Now it's not clear what will happen without looking at check_unused implementation.</pre>
</div>
<br />
<p>- Radek</p>
<br />
<p>On April 4th, 2013, 6:33 p.m. CEST, Jan Safranek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for OpenLMI Developers.</div>
<div>By Jan Safranek.</div>
<p style="color: grey;"><i>Updated April 4, 2013, 6:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-storage
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added checks to overwrite only unused devices.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py <span style="color: grey">(195a66e6cdc8f98e054aa3d6e7efb2306d721871)</span></li>
<li>src/openlmi/storage/LMI_FileSystemConfigurationService.py <span style="color: grey">(f8b76551652443e1c53e3b592a52a3c0bb740494)</span></li>
<li>src/openlmi/storage/LMI_StorageConfigurationService.py <span style="color: grey">(0abd5099b6ebb707abf95bbc6bdbc64951f3128a)</span></li>
</ul>
<p><a href="http://reviewboard-openlmi.rhcloud.com/r/95/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>