[netcf-devel] Preparing for freebsd support pull request

Laine Stump laine at laine.org
Fri May 11 00:53:11 UTC 2012


On 05/10/2012 08:07 PM, Sean Bruno wrote:
> So, Hiren and I are approaching our first milestone, where we think that
> we're feature complete for freebsd.  We're working out a few details at
> the moment, but its starting to look good.
>
> In order for you guys to pull from us, what's the standard process for
> us to follow such that you can review, accept(and/or reject) and pull
> from our tree.
>
> I assume there's some kind of "generate review-able patches" guidelines
> we should follow to make your lives easy.

Pretty simple, really - just make sure your patches are on a local git
branch that's based off the fedorahosted master branch, and use git
send-email --compose -<# of patches>, giving the introductory message
the subject [PATCH 0/<# of patches>] <something descriptive> and a short
overview.

A series of small patches is much better than a single monolithic patch.
Especially - if you've done any refactoring of the existing code to make
your code fit in better, it would be better to put that first in a
separate patch (such that applying it would have 0 functional effect),
then your port-specific stuff in later patches.



More information about the netcf-devel mailing list