[PATCH v2 3/4] Fix make distcheck

Doug Goldstein cardoe at gentoo.org
Thu Nov 8 15:28:03 UTC 2012


On Thu, Nov 8, 2012 at 7:39 AM, Jiri Popelka <jpopelka at redhat.com> wrote:
> Hi,
>
>
> On 11/08/2012 05:00 AM, Doug Goldstein wrote:
>>
>> -install-service:
>> -       mkdir -p $(DESTDIR)$(SYSTEMD_UNITDIR)
>> -       $(INSTALL) firewalld.service $(DESTDIR)$(SYSTEMD_UNITDIR)
>> +install-service: install-sysconfig
>> +       $(MKDIR_P) $(DESTDIR)$(prefix)$(SYSTEMD_UNITDIR)
>> +       $(INSTALL_DATA) $(srcdir)/firewalld.service
>> $(DESTDIR)$(prefix)$(SYSTEMD_UNITDIR)/firewalld.service
>
>
> I don't think the $(prefix) is what we want here.
> If you want to install the service into /usr/lib/systemd/system/ instead of
> the default /lib/systemd/system/
> you can use
> ./configure --with-systemd-unitdir=/usr/lib/systemd/system/
>
> which is actually what we do when creating the rpm for Fedora
> so I think we could change (configure.in) the SYSTEMD_UNITDIR to be
> /usr/lib/systemd/system/ by default.
> I can do that if we all agree.
>
> I've removed the $(prefix) and everything seems OK now.
>
> --
> Jiri

Problem is without the $(prefix) it will fail a make distcheck. That's
fine however as I was likely going to adopt the way the systemd unit
path is provided in other projects in a follow on patch.

-- 
Doug Goldstein


More information about the firewalld-devel mailing list