[PATCH v2 3/4] Fix make distcheck

Jiri Popelka jpopelka at redhat.com
Thu Nov 8 13:39:01 UTC 2012


Hi,

On 11/08/2012 05:00 AM, Doug Goldstein wrote:
> -install-service:
> -	mkdir -p $(DESTDIR)$(SYSTEMD_UNITDIR)
> -	$(INSTALL) firewalld.service $(DESTDIR)$(SYSTEMD_UNITDIR)
> +install-service: install-sysconfig
> +	$(MKDIR_P) $(DESTDIR)$(prefix)$(SYSTEMD_UNITDIR)
> +	$(INSTALL_DATA) $(srcdir)/firewalld.service $(DESTDIR)$(prefix)$(SYSTEMD_UNITDIR)/firewalld.service

I don't think the $(prefix) is what we want here.
If you want to install the service into /usr/lib/systemd/system/ instead 
of the default /lib/systemd/system/
you can use
./configure --with-systemd-unitdir=/usr/lib/systemd/system/

which is actually what we do when creating the rpm for Fedora
so I think we could change (configure.in) the SYSTEMD_UNITDIR to be 
/usr/lib/systemd/system/ by default.
I can do that if we all agree.

I've removed the $(prefix) and everything seems OK now.

--
Jiri


More information about the firewalld-devel mailing list