[patch] Fix for PIE with both -e and --core in use

Mark Wielaard mjw at redhat.com
Wed Nov 28 16:03:04 UTC 2012


On Wed, 2012-11-28 at 16:35 +0100, Jan Kratochvil wrote:
> Modifiable is struct argp_state:
> 
> # static error_t
> # parse_opt (int key, char *arg, struct argp_state *state)
> 
> But one can call parse_opt for arbitrary number of different struct argp_state
> structures in arbitrary order in arbitrary states of their execution (even if
> no threads are in use).
> 
> Is there still a disagreement?

I don't like a new field in struct Dwfl_Module that is only used for
this single thing. So if we can store the state somewhere else that
would be nice.

I see what you are saying can happen theoretically, but have a little
trouble imagining when this would every happen. If you are just using
parse_argp for command line parsing I don't really see how that would
happen. Are you thinking of some server program that would reuse
dwfl_standard_argp () multiple times?

Thanks,

Mark



More information about the elfutils-devel mailing list