cluster: RHEL510 - dirent_repair needs to mark the buffer as modified

Bob Peterson rpeterso at fedoraproject.org
Fri Apr 5 13:45:10 UTC 2013


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=d078d98871ee8065ba0421bdc76c987bf50a428e
Commit:        d078d98871ee8065ba0421bdc76c987bf50a428e
Parent:        f48938510d7b96e93b9578a68d1e854783f95e87
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Mon Aug 8 14:47:49 2011 -0500
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Fri Apr 5 06:24:59 2013 -0700

dirent_repair needs to mark the buffer as modified

This patch adds a call to bmodified to function dirent_repair.  Without
setting the modified bit, directory repairs may be forgotten and never
written back to disk, leaving the damage in place.

rhbz#877150
---
 gfs2/fsck/metawalk.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index 119271d..6b3c7f0 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -278,6 +278,7 @@ static int dirent_repair(struct gfs2_inode *ip, struct gfs2_buffer_head *bh,
 		de->de_rec_len = GFS2_DIRENT_SIZE(de->de_name_len);
 	}
 	gfs2_dirent_out(de, (char *)dent);
+	bmodified(bh);
 	return 0;
 }
 


More information about the cluster-commits mailing list