cluster: RHEL510 - fsck.gfs2: get rid of triple negative logic

Bob Peterson rpeterso at fedoraproject.org
Fri Apr 5 13:45:08 UTC 2013


Gitweb:        http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=f48938510d7b96e93b9578a68d1e854783f95e87
Commit:        f48938510d7b96e93b9578a68d1e854783f95e87
Parent:        3be02e038736edcaa1be6f0d68661715dedb77d6
Author:        Bob Peterson <rpeterso at redhat.com>
AuthorDate:    Mon Aug 8 14:44:46 2011 -0500
Committer:     Bob Peterson <rpeterso at redhat.com>
CommitterDate: Fri Apr 5 06:24:59 2013 -0700

fsck.gfs2: get rid of triple negative logic

This patch changes the logic of the code from being triple-negative
to single-negative so it won't twist your brain into knots.

rhbz#877150
---
 gfs2/fsck/metawalk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gfs2/fsck/metawalk.c b/gfs2/fsck/metawalk.c
index b93447f..119271d 100644
--- a/gfs2/fsck/metawalk.c
+++ b/gfs2/fsck/metawalk.c
@@ -944,7 +944,7 @@ static int delete_block_if_notdup(struct gfs2_inode *ip, uint64_t block,
 	uint8_t q;
 	struct duptree *d;
 
-	if (!valid_block(ip->i_sbd, block) != 0)
+	if (!valid_block(ip->i_sbd, block))
 		return -EFAULT;
 
 	q = block_type(block);


More information about the cluster-commits mailing list