[master 1/1] Do not override StorageChecker.errors in StorageSpoke (#1252596)

vojtechtrefny installerbot-noreply at redhat.com
Thu Oct 1 13:17:51 UTC 2015


In reply to line 1041 of pyanaconda/ui/gui/spokes/storage.py:

Errors are used in the dialog (they are not part of the label) and the dialog itself need two more attributes from StorageSpoke -- five arguments in total. The only part that is 100% same and could be easily moved to a function is the quit part and I'm not sure it's worth it moving two lines into method.

-- 
To view this comment on github, visit https://github.com/vojtechtrefny/anaconda/commit/53bfc00d43f7be0c966705b9cef346a37817ed99#commitcomment-13540857


More information about the anaconda-patches mailing list