[rhinstaller/anaconda/pulls/377 f23-branch] Move UEFI to special category in Custom spoke (#1183880)

jkonecny12 installerbot-noreply at redhat.com
Thu Oct 1 13:54:25 UTC 2015


> I don't like the name "UEFI partitions". We've avoided the word "partition" in general, and as adamw pointed out in IRC is seems awfully specific. We'll likely have this same situation on other platforms. Perhaps the name should be more generic.

Are you have some idea about how it should be named? Only "UEFI" seems little odd.

> I think it's accidental that these are showing up under a DATA heading. Regardless, I don't think it belongs under any heading. I think there should probably be a different Page subclass that these guys live in, similar to how there's an Unknown page. In fact you might just be able to borrow from that.
 
I missed this solution, good idea. I tested it and it works nice. I'll change it to `UnknownPage`.

> I find it a little weird that there can be multiple selectors with different names but the same device. I assume that's because it's part of multiple OSes? I feel like that's hard to discover here. Could they perhaps be grouped together but separated from other possibly shared UEFI partitions? That is, in the next-to-last screenshot, could the two sda1s be their own page, vda1s be their own, etc.? I don't know if that would look good though. It might be more confusing.

Yeah that could be but how you want to name the category `UEFI Shared` any idea? Also this will make the patch bigger. I think this part should go only to master. Question is, if only this part or whole patch and use the @AdamWill version instead.

> What happens when you delete just the first sda1 selector in the next-to-last screenshot? Does the other one disappear as well, or do you have to click delete twice to actually delete one thing?

Now it remove all sda1 items. I personally don't know which method is better if remove all or only one? From implementation point of view there could be some counter but as before it makes the patch bigger and it should go only to master though.


-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/377


More information about the anaconda-patches mailing list