[rhinstaller/anaconda/pulls/35 master] Missing local variable check

dashea installerbot-noreply at redhat.com
Fri Mar 13 01:50:49 UTC 2015


What I mean is that we don't want to keep the old message. The goal of this method is that if there are no incomplete spokes, and there is either no checker or no errors from the checker, clear the message. self._warningMsg was added as state for only this method, at least for now, so if there are no possible warning messages that don't come from this method.

By setting warning to self._warningMsg instead of None, once self._warningMsg has been set by this method, it will never be reset back to None once all the spokes are complete. I think it was fine when you had "warning = None" because there is no information to lose, because there are no warnings outside of this method.

Obviously this all could be clarified in the actual code, either with a comment or better variable name. But I think that can be fixed later. For the sake of getting things working again, if you're ok with it I'll use the previous version, https://github.com/rhinstaller/anaconda/commit/b110525a7435a20dc3f180f27d5492c5c65aa558
-- 
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/35


More information about the anaconda-patches mailing list