[rhinstaller/anaconda/pulls/35 master] Missing local variable check
usta
installerbot-noreply at redhat.com
Fri Mar 13 00:21:48 UTC 2015
@dashea with current ( 905fbaf ) it will keep old message and
change it if _incompleteSpokes==0 and _checker.check() True to checker's error_message
and if error_message is different than current _warningMsg it clears old one ( clear_info )
and shows new message until new error message comes.
If we did it like previous one ( warning=None ) we always clear message
(because it will be different than before ) maybe i lost in code but it looks like @mulkieran
is right here
def _updateContinue(self):
+ warning = self._warningMsg
if len(self._incompleteSpokes) == 0:
if self._checker and not self._checker.check():
warning = self._checker.error_message
else:
warning = _("Please complete items marked with this icon before continuing to the next step.")
# Check that this warning isn't already set to avoid spamming the
# info bar with incomplete spoke messages when the hub starts
if warning != self._warningMsg:
self.clear_info()
self.set_warning(warning)
self._warningMsg = warning
self._updateContinueButton()
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/35
More information about the anaconda-patches
mailing list