[PATCH python-meh] Run pylint as part of "make ci".
Martin Kolman
mkolman at redhat.com
Wed Jul 29 15:50:26 UTC 2015
On Tue, 2015-07-28 at 13:20 -0400, Chris Lumens wrote:
> Also, use sys.exit instead of os._exit to make sure pocketlint's
> atexit
> handler runs.
> ---
> Makefile | 2 +-
> tests/pylint/runpylint.py | 5 ++---
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a59aff2..8df17e7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -84,6 +84,6 @@ bumpver: potfile
> sed -i "s/Version: $(VERSION)/Version: $$NEWVERSION/" python
> -meh.spec ; \
> sed -i "s/version='$(VERSION)'/version='$$NEWVERSION'/"
> setup.py
>
> -ci: test
> +ci: check test
>
> .PHONY: clean install tag archive local
> diff --git a/tests/pylint/runpylint.py b/tests/pylint/runpylint.py
> index 2fbdb5c..146d04a 100755
> --- a/tests/pylint/runpylint.py
> +++ b/tests/pylint/runpylint.py
> @@ -1,6 +1,6 @@
> #!/usr/bin/python3
>
> -import os
> +import sys
>
> from pocketlint import PocketLintConfig, PocketLinter
>
> @@ -16,5 +16,4 @@ if __name__ == "__main__":
> conf = MehLintConfig()
> linter = PocketLinter(conf)
> rc = linter.run()
> - os._exit(rc)
> -
> + sys.exit(rc)
Yeah, looks good! :-)
More information about the anaconda-patches
mailing list