[PATCH python-meh] Run pylint as part of "make ci".

David Shea dshea at redhat.com
Tue Jul 28 20:37:53 UTC 2015


On 07/28/2015 01:20 PM, Chris Lumens wrote:
> Also, use sys.exit instead of os._exit to make sure pocketlint's atexit
> handler runs.
> ---
>   Makefile                  | 2 +-
>   tests/pylint/runpylint.py | 5 ++---
>   2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index a59aff2..8df17e7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -84,6 +84,6 @@ bumpver: potfile
>   	sed -i "s/Version: $(VERSION)/Version: $$NEWVERSION/" python-meh.spec ; \
>   	sed -i "s/version='$(VERSION)'/version='$$NEWVERSION'/" setup.py
>   
> -ci: test
> +ci: check test
>   
>   .PHONY: clean install tag archive local
> diff --git a/tests/pylint/runpylint.py b/tests/pylint/runpylint.py
> index 2fbdb5c..146d04a 100755
> --- a/tests/pylint/runpylint.py
> +++ b/tests/pylint/runpylint.py
> @@ -1,6 +1,6 @@
>   #!/usr/bin/python3
>   
> -import os
> +import sys
>   
>   from pocketlint import PocketLintConfig, PocketLinter
>   
> @@ -16,5 +16,4 @@ if __name__ == "__main__":
>       conf = MehLintConfig()
>       linter = PocketLinter(conf)
>       rc = linter.run()
> -    os._exit(rc)
> -
> +    sys.exit(rc)

Ack.


More information about the anaconda-patches mailing list