[master 5/6] dd-refactor: new driver_updates.py + tests
wgwoods
installerbot-noreply at redhat.com
Wed Jul 8 16:00:46 UTC 2015
In reply to line 126 of dracut/driver_updates.py:
> You use kwargs in the DeviceInfo class later on to prevent having lots of args.
Well, kwargs gets used there because the keys output by `blkid` aren't predictable - they vary wildly depending on the block device.
But the output of `dd_list` is well-documented and completely controlled by us, and I prefer to have at least a _little_ type-safety if I can.
I could maybe use `namedtuple` here, though, but I wanted to avoid pulling in more dependencies?
--
To view this comment on github, visit https://github.com/wgwoods/anaconda/commit/d2698c0e08d29b5754db8e7a42e1dfc7bd79e6aa#commitcomment-12065463
More information about the anaconda-patches
mailing list