[pykickstart][PATCH] Add support for specifying thin pool profile
vpodzime at redhat.com
Tue Sep 30 16:36:24 UTC 2014
On Mon, 2014-09-22 at 11:10 -0400, Chris Lumens wrote:
> > > Is it possible we will one day want to add something else to the logvol
> > > command that could be named "profile"? I feel the current option name
> > > is too generic and we'll regret it later.
> > Not much possible, as the '--profile' option is a generic option for the
> > 'lvm' command documented in lvm (8). Thus I think it won't be ever used
> > for anything else.
> Definitely - profile is something used by LVM. However the man page
> doesn't say it is specific to thinp support. The pykickstart patch here
> makes it an error to use --profile without --thinpool. What I am
> wondering is if that's too strict.
Now I get what you mean. Yes, you're right, it is too strict I think.
AFAICT the --profile option is only used for thin pools, but lvm (8)
doesn't specify that strictly so it may be used for other things as well
in the future. I'm dropping that requirement from the patch.
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches