[pykickstart][PATCH] Add support for specifying thin pool profile

Chris Lumens clumens at redhat.com
Mon Sep 22 15:10:21 UTC 2014

> > Is it possible we will one day want to add something else to the logvol
> > command that could be named "profile"?  I feel the current option name
> > is too generic and we'll regret it later.
> Not much possible, as the '--profile' option is a generic option for the
> 'lvm' command documented in lvm (8). Thus I think it won't be ever used
> for anything else.

Definitely - profile is something used by LVM.  However the man page
doesn't say it is specific to thinp support.  The pykickstart patch here
makes it an error to use --profile without --thinpool.  What I am
wondering is if that's too strict.  If the intention is to have a
--profile that must be used with --thinpool, perhaps the option should
be named differently.  On the other hand, if we will later use --profile
for some other LVM-related purpose, perhaps the check for --thinpool
also being specified does not need to be there.

- Chris

More information about the anaconda-patches mailing list