Let's add some DASDs ....again (#1070115)

Samantha N. Bueno sbueno+anaconda at redhat.com
Tue Sep 2 16:15:54 UTC 2014


Also, I've applied one fix locally already....adding
pyanaconda/ui/gui/spokes/advstorage/dasd.py to po/POTFILES.in

On Tue, Sep 02, 2014 at 08:39:53AM -0400, Samantha N. Bueno wrote:
> Contains all suggestions from prior review, minus bcl's one suggestion
> for blivet patches, which I later realized isn't needed:
> 
> > > +    if dev is None or dev == "":                                                            
> > > +        raise ValueError("You have not specified a device number or the number is invalid") 
> > > +    dev = dev.lower()                                                                       
> > > +    bus = dev[:string.rfind(dev, ".") + 1]                                                  
> > > +    dev = dev[string.rfind(dev, ".") + 1:]                                                  
> >                                                                                                
> > I'd pull the rfind out into its own variable so you can check for -1                           
> > and raise an error (assuming no . is an error)
> 
> Lack of '.' is not necessarily an error. There's now a docstring which
> notes valid formats for the device number, but basically either 0.0.abcd
> or abcd (or caps are also ok if a-f appear in the dev number).
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list