[anaconda][master/rhel7-branch][PATCH 2/2] Add dialog box for adding DASDs. (#1070115)

Vratislav Podzimek vpodzime at redhat.com
Wed Sep 3 11:52:38 UTC 2014


On Tue, 2014-09-02 at 08:39 -0400, Samantha N. Bueno wrote:
> This is the dialog box which pops up prompting for info so more (ECKD)
> DASDs can be added.
> 
> Upon a successful add, users are returned to the filter. Due to the fact
> that DASDs are detected as local storage, newly-added DASDs here are not
> going to show up in the Search or System Z Devices tab. They do appear
> under "Local Standard Disks" back in the main storage spoke though.
> 
> Resolves: rhbz#1070115
> ---
>  pyanaconda/ui/gui/spokes/advstorage/dasd.glade | 362 +++++++++++++++++++++++++
>  pyanaconda/ui/gui/spokes/advstorage/dasd.py    | 139 ++++++++++
>  2 files changed, 501 insertions(+)
>  create mode 100644 pyanaconda/ui/gui/spokes/advstorage/dasd.glade
>  create mode 100644 pyanaconda/ui/gui/spokes/advstorage/dasd.py
> 

> diff --git a/pyanaconda/ui/gui/spokes/advstorage/dasd.py b/pyanaconda/ui/gui/spokes/advstorage/dasd.py
> new file mode 100644
> index 0000000..555960e
> --- /dev/null
> +++ b/pyanaconda/ui/gui/spokes/advstorage/dasd.py
> @@ -0,0 +1,139 @@
> +# DASD configuration dialog
> +#
> +# Copyright (C) 2014  Red Hat, Inc.
> +#
> +# This copyrighted material is made available to anyone wishing to use,
> +# modify, copy, or redistribute it subject to the terms and conditions of
> +# the GNU General Public License v.2, or (at your option) any later version.
> +# This program is distributed in the hope that it will be useful, but WITHOUT
> +# ANY WARRANTY expressed or implied, including the implied warranties of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
> +# Public License for more details.  You should have received a copy of the
> +# GNU General Public License along with this program; if not, write to the
> +# Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> +# 02110-1301, USA.  Any Red Hat trademarks that are incorporated in the
> +# source code or documentation are not subject to the GNU General Public
> +# License and may only be used or replicated with the express permission of
> +# Red Hat, Inc.
> +#
> +# Red Hat Author(s): Samantha N. Bueno <sbueno at redhat.com>
> +#
> +
> +from pyanaconda.ui.gui import GUIObject
> +from pyanaconda.ui.gui.utils import gtk_action_nowait
> +
> +from blivet.devicelibs.dasd import sanitize_dasd_dev_input, online_dasd
> +
> +__all__ = ["DASDDialog"]
> +
> +class DASDDialog(GUIObject):
> +    """ Gtk dialog which allows users to manually add DASD devices without
> +        having previously specified them in a parm file.
> +    """
> +    builderObjects = ["dasdDialog"]
> +    mainWidgetName = "dasdDialog"
> +    uiFile = "spokes/advstorage/dasd.glade"
> +
> +    def __init__(self, data, storage):
> +        GUIObject.__init__(self, data)
> +        self.storage = storage
> +        self.dasd = self.storage.dasd
> +
> +        self._discoveryError = None
> +
> +        self._update_devicetree = False
> +
> +        # grab all of the ui objects
> +        self._dasdNotebook = self.builder.get_object("dasdNotebook")
> +
> +        self._configureGrid = self.builder.get_object("configureGrid")
> +        self._conditionNotebook = self.builder.get_object("conditionNotebook")
> +
> +        self._startButton = self.builder.get_object("startButton")
> +        self._okButton = self.builder.get_object("okButton")
> +        self._cancelButton = self.builder.get_object("cancelButton")
> +
> +        self._deviceEntry = self.builder.get_object("deviceEntry")
> +
> +        self._spinner = self.builder.get_object("waitSpinner")
> +
> +    def refresh(self):
> +        self._deviceEntry.set_text("")
> +        self._deviceEntry.set_sensitive(True)
> +        self._startButton.set_sensitive(True)
> +
> +    def run(self):
> +        rc = self.window.run()
> +        self.window.destroy()
> +        # We need to call this to get the device nodes to show up
> +        # in our devicetree.
> +        if self._update_devicetree:
> +            self.storage.devicetree.populate()
When I see this call I imagine something that takes quite a long time.
If that's the case, we would probably need to do it before the dialog is
destroyed, informing user what's going on somehow (label+spinner). Maybe
as an extra patch if/once somebody complains.

> +        return rc
> +
> +    def on_start_clicked(self, *args):
> +        """ Go through the process of validating entry contents and then
> +            attempt to add the device.
> +        """
> +        # First update widgets
> +        self._startButton.hide()
> +        self._cancelButton.set_sensitive(False)
> +        self._okButton.set_sensitive(False)
> +
> +        self._conditionNotebook.set_current_page(1)
> +        self._configureGrid.set_sensitive(False)
> +        self._deviceEntry.set_sensitive(False)
I'd like to avoid studying the .glade file, but if these two widgets are
on the page 1 of the _conditionNetbook, you don't have to make them
insensitive when they go away anyway.

> +
> +        self._conditionNotebook.set_current_page(1)
This don't have to be done twice, I think. :)

> +        try:
> +            device = sanitize_dasd_dev_input(self._deviceEntry.get_text())
> +        except ValueError as e:
> +            _config_error = str(e)
> +            self.builder.get_object("deviceErrorLabel").set_text(_config_error)
> +            self._conditionNotebook.set_current_page(2)
> +            self._configureGrid.set_sensitive(True)
> +            self._cancelButton.set_sensitive(True)
> +            self._deviceEntry.set_sensitive(True)
The same here with the (in)sensitive widgets on the page that goes away.

> +            return
> +
> +        self._spinner.start()
> +
> +        self._discover(device)
> +        self._check_discover()
> +
> +    @gtk_action_nowait
> +    def _check_discover(self):
> +        """ After the DASD discover thread runs, check to see whether a valid
> +            device was discovered. Display an error message if not.
> +        """
> +
> +        self._spinner.stop()
> +
> +        if self._discoveryError:
> +            # Failure, display a message and leave the user on the dialog so
> +            # they can try again (or cancel)
> +            self.builder.get_object("deviceErrorLabel").set_text(self._discoveryError)
> +            self._discoveryError = None
> +            self._conditionNotebook.set_current_page(2)
> +            self._configureGrid.set_sensitive(True)
> +            self._deviceEntry.set_sensitive(True)
And here.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list