[blivet][rhel7-branch] Pass a list of string items to log_method_return. (#1155984)

Anne Mulhern amulhern at redhat.com
Thu Oct 30 14:30:24 UTC 2014





----- Original Message -----
> From: "Samantha N. Bueno" <sbueno+anaconda at redhat.com>
> To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> Sent: Thursday, October 30, 2014 9:09:36 AM
> Subject: Re: [blivet][rhel7-branch] Pass a list of string items to	log_method_return. (#1155984)
> 
> On Thu, Oct 30, 2014 at 08:34:20AM -0400, Anne Mulhern wrote:
> > ----- Original Message -----
> > > From: "Anne Mulhern" <amulhern at redhat.com>
> > > To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> > > Sent: Thursday, October 30, 2014 8:11:03 AM
> > > Subject: Re: [blivet][rhel7-branch] Pass a list of string items to
> > > 	log_method_return. (#1155984)
> > > ----- Original Message -----
> > > > From: "Samantha N. Bueno" <sbueno+anaconda at redhat.com>
> > > > To: anaconda-patches at lists.fedorahosted.org
> > > > Sent: Wednesday, October 29, 2014 1:59:50 PM
> > > > Subject: [blivet][rhel7-branch] Pass a list of string items to
> > > > 	log_method_return. (#1155984)
> > > > 
> > > > Otherwise there is some serious lagging in the UI when you
> > > > select/de-select
> > > > a disk in the anaconda storage spoke.
> > > > 
> > > >  <>
> > > 
> > > Might be slightly better to use str(r) instead of r.name, to be
> > > consistent.
> 
> I think it is fine as-is, and dlehman even suggested this. I do not see
> why it is better to use str() versus the attr.
> 

Well, I can't remember a time when dlehman has ever done exactly what he first suggested ;)

But I take back the suggestion because...
one of the things that __str__ representation gives you is size,
which can be quite computationally expensive to display when the
device exists.

<-- SNIP -->

Turns out we've been logging lists of devices since the blivet repo got started,
and only worried about it now.

Clearly we need to fix logging generally, but how?

- mulhern


More information about the anaconda-patches mailing list