[blivet][rhel7-branch] Pass a list of string items to log_method_return. (#1155984)

Samantha N. Bueno sbueno+anaconda at redhat.com
Thu Oct 30 13:09:36 UTC 2014


On Thu, Oct 30, 2014 at 08:34:20AM -0400, Anne Mulhern wrote:
> ----- Original Message -----
> > From: "Anne Mulhern" <amulhern at redhat.com>
> > To: "anaconda patch review" <anaconda-patches at lists.fedorahosted.org>
> > Sent: Thursday, October 30, 2014 8:11:03 AM
> > Subject: Re: [blivet][rhel7-branch] Pass a list of string items to	log_method_return. (#1155984)
> > ----- Original Message -----
> > > From: "Samantha N. Bueno" <sbueno+anaconda at redhat.com>
> > > To: anaconda-patches at lists.fedorahosted.org
> > > Sent: Wednesday, October 29, 2014 1:59:50 PM
> > > Subject: [blivet][rhel7-branch] Pass a list of string items to
> > > 	log_method_return. (#1155984)
> > > 
> > > Otherwise there is some serious lagging in the UI when you select/de-select
> > > a disk in the anaconda storage spoke.
> > > 
> > >  <>
> > 
> > Might be slightly better to use str(r) instead of r.name, to be consistent.

I think it is fine as-is, and dlehman even suggested this. I do not see
why it is better to use str() versus the attr.

> > Otherwise, ack, and thanks.
> > 
> > - mulhern
> > _______________________________________________
> > anaconda-patches mailing list
> > anaconda-patches at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> > 
> 
> Also, this should definitely go into master...and probably f21-branch as well.
> 
> It occurs to me that the commit message should say something about the fact that
> the awful slowdown is due to the fact that str(list) calls __repr__ on the
> underlying objects and that device __repr__ happens to be hideously expensive.

Sure I'll change the commit msg. And yes, bcl mentioned in irc this
should also go into the other branches.
 
> - mulhern
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches


More information about the anaconda-patches mailing list