[master/f21 v3] Fix # handling in SimpleConfigFile (#1045687)

Anne Mulhern amulhern at redhat.com
Wed Oct 15 14:41:15 UTC 2014





----- Original Message -----
> From: "Chris Lumens" <clumens at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Wednesday, October 15, 2014 9:48:43 AM
> Subject: Re: [master/f21 v3] Fix # handling in SimpleConfigFile (#1045687)
> 
> > Above three lines could be:
> >            padding = " " if comment else ""
> 
> I really, really, really hate this style.  It reminds me of Perl, and I
> hate Perl.

That's so weird. It reminds me of all those languages that emphasize referential
transparency, i.e., not-Perl.
Which is nice for me, because Perl is one of my least favourite languages.

I guess the ordering of the expression parts could have been a little bit better chosen.

> 
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 


More information about the anaconda-patches mailing list