[master/f21 v3] Fix # handling in SimpleConfigFile (#1045687)

David Shea dshea at redhat.com
Wed Oct 15 13:54:39 UTC 2014


On 10/15/2014 09:48 AM, Chris Lumens wrote:
>> Above three lines could be:
>>             padding = " " if comment else ""
> I really, really, really hate this style.  It reminds me of Perl, and I
> hate Perl.
>
> - Chris
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches

I'll second that. It's like adding a big fat "PS: actually I meant..." 
at the end of an otherwise ok looking statement, and I think it would be 
better if we all pretended that Python doesn't have conditional expressions.


More information about the anaconda-patches mailing list