[master][PATCH] Really exit when "Exit installer" in the error dialog is clicked

Vratislav Podzimek vpodzime at redhat.com
Thu Oct 2 16:12:50 UTC 2014


On Thu, 2014-10-02 at 10:49 -0400, Chris Lumens wrote:
> > diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
> > index df98360..0a16245 100644
> > --- a/pyanaconda/ui/gui/__init__.py
> > +++ b/pyanaconda/ui/gui/__init__.py
> > @@ -670,6 +670,9 @@ class GraphicalUserInterface(UserInterface):
> >              dlg.run()
> >              dlg.window.destroy()
> >  
> > +        # the dialog has the only button -- "Exit installer", so just do so
> > +        sys.exit(0)
> > +
> 
> We probably want to exit(1), yeah?
> 
> Also it might be worth auditing where we call showError and removing the
> code that deals with return values and such, given that we're just going
> to exit.  You know, for clarity.
Both good points, will fix and check the calls.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list