[master][PATCH] Really exit when "Exit installer" in the error dialog is clicked

Chris Lumens clumens at redhat.com
Thu Oct 2 14:49:36 UTC 2014


> diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
> index df98360..0a16245 100644
> --- a/pyanaconda/ui/gui/__init__.py
> +++ b/pyanaconda/ui/gui/__init__.py
> @@ -670,6 +670,9 @@ class GraphicalUserInterface(UserInterface):
>              dlg.run()
>              dlg.window.destroy()
>  
> +        # the dialog has the only button -- "Exit installer", so just do so
> +        sys.exit(0)
> +

We probably want to exit(1), yeah?

Also it might be worth auditing where we call showError and removing the
code that deals with return values and such, given that we're just going
to exit.  You know, for clarity.

- Chris


More information about the anaconda-patches mailing list