[PATCH 4/5] Change management of Device parents to use a simple list interface.
David Lehman
dlehman at redhat.com
Wed Mar 26 13:59:13 UTC 2014
On Wed, 2014-03-26 at 09:51 +0100, Vratislav Podzimek wrote:
> > @@ -2550,12 +2608,12 @@ class LVMVolumeGroupDevice(ContainerDevice):
> > @property
> > def pvs(self):
> > """ A list of this VG's PVs """
> > - return self.parents[:] # we don't want folks changing our list
> > + return self.parents
> >
> > @property
> > def lvs(self):
> > """ A list of this VG's LVs """
> > - return self._lvs[:] # we don't want folks changing our list
> > + return self._lvs
> I don't understand how these two changes are related to the patch.
> Shouldn't they go into a separate patch?
They are unrelated. I'll split them out.
>
> Otherwise this looks good to me.
>
More information about the anaconda-patches
mailing list