[PATCH 4/5] Change management of Device parents to use a simple list interface.

Vratislav Podzimek vpodzime at redhat.com
Wed Mar 26 08:51:42 UTC 2014


> @@ -2550,12 +2608,12 @@ class LVMVolumeGroupDevice(ContainerDevice):
>      @property
>      def pvs(self):
>          """ A list of this VG's PVs """
> -        return self.parents[:]  # we don't want folks changing our list
> +        return self.parents
>  
>      @property
>      def lvs(self):
>          """ A list of this VG's LVs """
> -        return self._lvs[:]     # we don't want folks changing our list
> +        return self._lvs
I don't understand how these two changes are related to the patch.
Shouldn't they go into a separate patch?

Otherwise this looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list