[master] Few more little steps to sane Custom spoke
Vratislav Podzimek
vpodzime at redhat.com
Fri Mar 14 08:51:03 UTC 2014
On Mon, 2014-03-10 at 14:22 +0100, Vratislav Podzimek wrote:
> 13 small and hopefully easy-understandable patches for the Custom partitioning
> spoke and the related code. Another ~15 will probably appear during this week,
> but these are the first steps.
>
> Vratislav Podzimek (13):
> Rename the __storage attrbitue to a more propriate name
> Move translated_new_install_name to the right place
> Simplify label validation and error reporting
> Simplify mountpoint validation and error reporting
> Make custom partitioning helper constants look as constants
> Implement a function to get container type name
> Make getting raid level less hacky
> Make code to get Size instance from user's input reusable
> Add and use MountpointSelector's attributes and properties
> Implement and use a decorator for initialization needed
> Fix typo in the comment
> Decide on supported RAID levels in a better way
> Make the ui_storage_logger reusable
>
> pyanaconda/product.py | 4 +
> pyanaconda/storage_utils.py | 92 +++++++
> pyanaconda/ui/gui/spokes/custom.glade | 45 +--
> pyanaconda/ui/gui/spokes/custom.py | 305 +++++++++++----------
> .../ui/gui/spokes/lib/custom_storage_helpers.glade | 45 +--
> .../ui/gui/spokes/lib/custom_storage_helpers.py | 167 +++--------
> widgets/python/AnacondaWidgets.py | 20 ++
> 7 files changed, 331 insertions(+), 347 deletions(-)
> create mode 100644 pyanaconda/storage_utils.py
I've applied all the suggested changes and I'm gonna push those patches
as I expect no additional feedback on them. We can always do additional
tweaks later or even revert some of those patches if the cause troubles.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
More information about the anaconda-patches
mailing list