[master] Few more little steps to sane Custom spoke

Martin Kolman mkolman at redhat.com
Tue Mar 11 15:39:32 UTC 2014


On Mon, 2014-03-10 at 14:22 +0100, Vratislav Podzimek wrote:
> 13 small and hopefully easy-understandable patches for the Custom partitioning
> spoke and the related code. Another ~15 will probably appear during this week,
> but these are the first steps.
> 
> Vratislav Podzimek (13):
>   Rename the __storage attrbitue to a more propriate name
>   Move translated_new_install_name to the right place
>   Simplify label validation and error reporting
>   Simplify mountpoint validation and error reporting
>   Make custom partitioning helper constants look as constants
>   Implement a function to get container type name
>   Make getting raid level less hacky
>   Make code to get Size instance from user's input reusable
>   Add and use MountpointSelector's attributes and properties
>   Implement and use a decorator for initialization needed
>   Fix typo in the comment
>   Decide on supported RAID levels in a better way
>   Make the ui_storage_logger reusable
> 
>  pyanaconda/product.py                              |   4 +
>  pyanaconda/storage_utils.py                        |  92 +++++++
>  pyanaconda/ui/gui/spokes/custom.glade              |  45 +--
>  pyanaconda/ui/gui/spokes/custom.py                 | 305 +++++++++++----------
>  .../ui/gui/spokes/lib/custom_storage_helpers.glade |  45 +--
>  .../ui/gui/spokes/lib/custom_storage_helpers.py    | 167 +++--------
>  widgets/python/AnacondaWidgets.py                  |  20 ++
>  7 files changed, 331 insertions(+), 347 deletions(-)
>  create mode 100644 pyanaconda/storage_utils.py
> 
Thanks for setting out to defuse the custom partitioning minefield!
The patches look good, ACK!



More information about the anaconda-patches mailing list