[PATCH] Mountpoint encrypted checkbox reflects container state (#1000031)

Vratislav Podzimek vpodzime at redhat.com
Mon Jun 30 06:44:39 UTC 2014


On Fri, 2014-06-27 at 11:09 -0700, Brian C. Lane wrote:
> On Thu, Jun 26, 2014 at 07:53:19PM -0500, David Lehman wrote:
> > On 06/26/2014 07:06 PM, Brian C. Lane wrote:
> > >When the container is encrypted the mountpoint's encryption checkbox is
> > >insensitive, but doesn't reflect the encrypted state. This changes the
> > >checkbox so that when it the container is encrypted it will be
> > >insensitive and checked as well as setting a tooltip saying "The
> > >Container is encrypted."
> > 
> > This could cause confusion since that checkbox means "encrypt this device
> > directly" when it is sensitive. I realize the tooltip might help for some
> > users.
> 
> I'm not sure that users understand the underlying logic that well :) I'm
> pretty sure they're going to look at it and say 'why isn't that
> encrypted? Why can't I click it?'
I must confirm that this is exactly what happens and many colleagues
report an Anaconda "bug" that they checked encryption and on the next
screen "Encrypted" is not checked and insensitive.

> 
> > 
> > Sometimes we change things because bug reporters ask us to and then we
> > realize later that we shouldn't have done it. I'm not necessarily saying
> > this is one of those times, but it has potential.
> 
> As it stands right now the encryption state of the container is hidden.
> I think this is better than adding some other indication of container
> encrypted state. If they attempt to click on it they will see the
> tooltip, and if the container's encryption state changes it will become
> sensitive and not set.
> 
> If it were possible to change the state of this checkbox while the
> container was encrypted, then I would agree, but you can't so it should
> reflect the actual state of things.
Still I think we should come up with some bigger change that would make
things clear. Going from a less clear to a bit clearer doesn't seem
like the right thing we should do, at least not on Rawhide. What about
that new Gtk popup floating thing? Couldn't we have the checkbox as it
is now and pop up the floating box with two checkboxes like "Mountpoint
only", "Container"?

That's just a first shot, but we should be able to come up with some
sound solution.

-- 
Vratislav Podzimek

Anaconda Rider | RHCE | Red Hat, Inc. | Brno - Czech Republic




More information about the anaconda-patches mailing list