[PATCH] Mountpoint encrypted checkbox reflects container state (#1000031)

Brian C. Lane bcl at redhat.com
Fri Jun 27 18:09:10 UTC 2014


On Thu, Jun 26, 2014 at 07:53:19PM -0500, David Lehman wrote:
> On 06/26/2014 07:06 PM, Brian C. Lane wrote:
> >When the container is encrypted the mountpoint's encryption checkbox is
> >insensitive, but doesn't reflect the encrypted state. This changes the
> >checkbox so that when it the container is encrypted it will be
> >insensitive and checked as well as setting a tooltip saying "The
> >Container is encrypted."
> 
> This could cause confusion since that checkbox means "encrypt this device
> directly" when it is sensitive. I realize the tooltip might help for some
> users.

I'm not sure that users understand the underlying logic that well :) I'm
pretty sure they're going to look at it and say 'why isn't that
encrypted? Why can't I click it?'

> 
> Sometimes we change things because bug reporters ask us to and then we
> realize later that we shouldn't have done it. I'm not necessarily saying
> this is one of those times, but it has potential.

As it stands right now the encryption state of the container is hidden.
I think this is better than adding some other indication of container
encrypted state. If they attempt to click on it they will see the
tooltip, and if the container's encryption state changes it will become
sensitive and not set.

If it were possible to change the state of this checkbox while the
container was encrypted, then I would agree, but you can't so it should
reflect the actual state of things.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)


More information about the anaconda-patches mailing list