[f21/master] Restrict the selected and insensitive style rules to anaconda widgets

Vratislav Podzimek vpodzime at redhat.com
Fri Jul 18 14:07:07 UTC 2014


On Fri, 2014-07-18 at 09:55 -0400, David Shea wrote:
> The wildcard selectors for the :selected rules were causing untoggled
> toggles on selected rows to appear the same as toggled toggles.
> ---
>  data/anaconda-gtk.css | 23 +++++++++++++++--------
>  1 file changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/data/anaconda-gtk.css b/data/anaconda-gtk.css
> index ce6c987..8d71f60 100644
> --- a/data/anaconda-gtk.css
> +++ b/data/anaconda-gtk.css
> @@ -158,17 +158,22 @@ AnacondaSpokeWindow #nav-box {
>  }
>  
>  /* These rules were removed when the Adwaita theme moved from
> - * gnome-themes-standard to gtk, and they were replaced with much more specific
> - * selectors. We need something like this for the selection highlights and
> - * shading for insensitivity to appear on the MountpointSelector, DiskOverview
> - * and SpokeSelector widgets. We could probably be specific to the Anaconda
> - * widgets, but on the other hand gtk can go to hell.
> + * gnome-themes-standard to gtk. The selectors had been wildcards, but after
> + * the move they were replaced with more specific selectors, because gtk is
> + * maintained by garbage people who don't care about how anyone else's
> + * applications look. We need to apply the old style to anconda's custom
> + * widgets in order for the selection highlight and insensitive shading to
> + * appear.
>   */
>  @define-color anaconda_selected_bg_color #4a90d9;
>  @define-color anaconda_selected_fg_color #ffffff;
>  
> -*:selected,
> -*:selected:focus {
> +AnacondaMountpointSelector:selected,
> +AnacondaDiskOverview:selected,
> +AnacondaSpokeSelector:selected,
> +AnacondaMountpointSelector:selected:focus,
> +AnacondaDiskOverview:selected:focus,
> +AnacondaSpokeSelector:selected:focus {
>      background-color: @anaconda_selected_bg_color;
>      color: @anaconda_selected_fg_color;
>  }
> @@ -178,7 +183,9 @@ AnacondaSpokeWindow #nav-box {
>  @define-color anaconda_internal_element_color #888a85;
>  @define-color anaconda_insensitive_borders shade(@anaconda_internal_element_color, 1.37);
>  
> -*:insensitive {
> +AnacondaMountpointSelector:insensitive,
> +AnacondaDiskOverview:insensitive,
> +AnacondaSpokeSelector:insensitive {
>      background-color: @anaconda_insensitive_bg_color;
>      color: @anaconda_insensitive_fg_color;
>      border-color: @anaconda_insensitive_borders;
ACK. I've seen more issues caused by this (insensitive buttons on the
Keyboard spoke looking wierd, for example).

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list