[PATCH] Add a basic test for ostree-based installs.

Colin Walters walters at verbum.org
Wed Jul 9 13:21:58 UTC 2014


On Mon, Jul 7, 2014, at 11:53 AM, Chris Lumens wrote:
> I'm looking for comments on the attached patch.  It allows for running
> anaconda in a VM through livemedia-creator to do an ostree-based install.
> Right now there is no verification of anything about contents of the
> installed
> system - it's assumed that a completed install is good enough.  It also
> doesn't do a very good job of cleanup.  Here's what I'm wondering:
> 
> (1) Is there some additional way that I should verify success besides
> just
>     whether the installation completed?  For instance, should I check for
>     certain files on the finished system?

In what context can we perform tests here?  Inside the %post?

To me the most valuable testing is integration testing - so for example
rather than test installation directly, test whether the system boots at
runtime and whether some functional tests pass.

> (2) Are there other aspects of ostree+anaconda that need to be tested?

The main risk in my mind is things in %post, or more generally things
Anaconda might do to change the OS configuration or content.  That said
I think we're in a relatively sane place now with the mounting setup,
and things appear similar enough to mainline.

But to pick a random one: some bits of Fedora write to /, such as
/.autorelabel.  That is no longer allowed since
https://bugzilla.gnome.org/show_bug.cgi?id=728006


More information about the anaconda-patches mailing list