[PATCH] Fix minimal install selection with incomplete kickstart (#1032066)

Martin Kolman mkolman at redhat.com
Tue Jan 14 12:22:16 UTC 2014


On Tue, 2014-01-14 at 10:37 +0100, Martin Kolman wrote:
> On Mon, 2014-01-13 at 11:50 -0800, Brian C. Lane wrote:
> > On Mon, Jan 13, 2014 at 06:44:22PM +0100, Martin Kolman wrote:
> > > Minimal install now will be correctly used after visiting
> > > the Software spoke when installing with an incomplete kickstart.
> > > 
> > > Signed-off-by: Martin Kolman <mkolman at redhat.com>
> > > ---
> > >  pyanaconda/ui/gui/spokes/software.py | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
> > > index b7725e0..fb1574b 100644
> > > --- a/pyanaconda/ui/gui/spokes/software.py
> > > +++ b/pyanaconda/ui/gui/spokes/software.py
> > > @@ -109,6 +109,13 @@ class SoftwareSelectionSpoke(NormalSpoke):
> > >          else:
> > >              self._errorMsgs = None
> > >              self._tx_id = self.payload.txID
> > 
> > I'd move this down into an else: just in case some other thread comes
> > along to check it right before setting it None. ACK other than that.
> OK, thanks, fixing locally.
Hmmm, it is already is in the else block of the try block. Did you mean
something else ?
> > 
> > > +            if flags.automatedInstall and not self.data.packages.seen:
> > > +                self._tx_id = None
> > 
> > 
> > 
> > 
> > > +            # If we are installing with a kickstart that does not specify packages,
> > > +            # we want the user to enter the Software spoke and confirm the software
> > > +            # selection. We do this be by resetting the transaction id, which
> > > +            # forces the user to visit the spoke and also makes sure any changes
> > > +            # he does in the spoke are respected.
> > >          finally:
> > >              hubQ.send_ready(self.__class__.__name__, False)
> > >              hubQ.send_ready("SourceSpoke", False)
> > > -- 
> > > 1.8.4.2
> > 
> > 
> 
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches




More information about the anaconda-patches mailing list