[PATCH] Fix minimal install selection with incomplete kickstart (#1032066)

Vratislav Podzimek vpodzime at redhat.com
Tue Jan 14 12:20:54 UTC 2014


On Mon, 2014-01-13 at 18:44 +0100, Martin Kolman wrote:
> Minimal install now will be correctly used after visiting
> the Software spoke when installing with an incomplete kickstart.
> 
> Signed-off-by: Martin Kolman <mkolman at redhat.com>
> ---
>  pyanaconda/ui/gui/spokes/software.py | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
> index b7725e0..fb1574b 100644
> --- a/pyanaconda/ui/gui/spokes/software.py
> +++ b/pyanaconda/ui/gui/spokes/software.py
> @@ -109,6 +109,13 @@ class SoftwareSelectionSpoke(NormalSpoke):
>          else:
>              self._errorMsgs = None
>              self._tx_id = self.payload.txID
> +            if flags.automatedInstall and not self.data.packages.seen:
> +                self._tx_id = None
> +            # If we are installing with a kickstart that does not specify packages,
> +            # we want the user to enter the Software spoke and confirm the software
> +            # selection. We do this be by resetting the transaction id, which
> +            # forces the user to visit the spoke and also makes sure any changes
> +            # he does in the spoke are respected.
I'd put the comment above the code not below it. Or maybe into the if
statement. Otherwise this looks good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list