[master][PATCH] Return the returned value in the fire_gtk_action

Anne Mulhern amulhern at redhat.com
Tue Feb 11 12:53:52 UTC 2014





----- Original Message -----
> From: "Vratislav Podzimek" <vpodzime at redhat.com>
> To: anaconda-patches at lists.fedorahosted.org
> Sent: Tuesday, February 11, 2014 4:38:56 AM
> Subject: [master][PATCH] Return the returned value in the fire_gtk_action
> 
> There's no reason for discarding the value. If caller is not interested in
> it,
> they can always not assign it anywhere.
> 
> Signed-off-by: Vratislav Podzimek <vpodzime at redhat.com>
> ---
>  pyanaconda/ui/gui/utils.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pyanaconda/ui/gui/utils.py b/pyanaconda/ui/gui/utils.py
> index 4feb5bb..d8d8bb2 100644
> --- a/pyanaconda/ui/gui/utils.py
> +++ b/pyanaconda/ui/gui/utils.py
> @@ -83,7 +83,7 @@ def fire_gtk_action(func, *args):
>      def gtk_action():
>          func(*args)
>  
> -    gtk_action()
> +    return gtk_action()
>  
>  def gtk_action_nowait(func):
>      """Decorator method which ensures every call of the decorated function
>      to be
> --
> 1.8.5.3
> 
> _______________________________________________
> anaconda-patches mailing list
> anaconda-patches at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
> 

Do you need to add a return to the body of gtk_action() to make this return meaningful?

- mulhern




More information about the anaconda-patches mailing list