[blivet:master 0/9] Almost the last pylint patches
David Lehman
dlehman at redhat.com
Thu Apr 24 18:28:17 UTC 2014
On 04/23/2014 04:49 PM, mulhern wrote:
> Fewer than 50 to go.
>
> Set device.format...I changed this because without the change the entire
> enclosing if-block does nothing. But this is a guess and maybe the if
> block should be removed instead.
Your patch does the right thing. This set looks good to me.
David
>
> mulhern (9):
> Correct comment on resizable property
> Add an attribute docstring for _resizable.
> Remove definition of LVMThinLogicalVolumeDevice._resizable
> Rewrite resize() method to depend on _resizable.
> Compress loop into generator list comprehension
> Get rid of a redefined builtin while simplifying method.
> Do not run pylint on sphinx generated conf.py
> Set device.format in else block of try/except/else.
> Rename to avoid redefining built-ins where the redefinition is method
> local.
>
> blivet/__init__.py | 16 +++----
> blivet/devices.py | 23 +++++-----
> blivet/devicetree.py | 32 ++++++--------
> blivet/pyudev.py | 14 +++---
> blivet/storage_log.py | 5 +--
> blivet/zfcp.py | 4 +-
> scripts/makeupdates | 26 +++++------
> tests/action_test.py | 88 ++++++++++++++++++-------------------
> tests/devicelibs_test/baseclass.py | 10 ++---
> tests/pylint/pylint-false-positives | 1 +
> tests/pylint/runpylint.sh | 2 +-
> tests/storagetestcase.py | 16 +++----
> 12 files changed, 116 insertions(+), 121 deletions(-)
>
More information about the anaconda-patches
mailing list