[blivet:master 0/9] Almost the last pylint patches

Vratislav Podzimek vpodzime at redhat.com
Thu Apr 24 05:55:27 UTC 2014


On Wed, 2014-04-23 at 17:49 -0400, mulhern wrote:
> Fewer than 50 to go.
> 
> Set device.format...I changed this because without the change the entire
> enclosing if-block does nothing. But this is a guess and maybe the if
> block should be removed instead.
>From the surrounding code the added else part seems to be the right fix,
although even without it it does something -- logs an error if there is
something weird.

Other than those two minor comments these all look good to me.

-- 
Vratislav Podzimek

Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic



More information about the anaconda-patches mailing list