Extracted patches for users.py
Colin Walters
walters at verbum.org
Mon Apr 7 17:52:15 UTC 2014
On Mon, Apr 7, 2014 at 7:01 AM, Vratislav Podzimek
<vpodzime at redhat.com> wrote:
> PATCH 1/2:
> The contextlib module is imported but not used in the patch. I can
> simply remove it before pushing, but I'm wondering if you tried to
> create a contextmanager for forking+chroot and it didn't work or if
> you
> didn't try it. It could be nice to use something like "with
> ForkedChild
> as child:"
Yeah, I started doing it as a context, but I think there was some
difficulty with the error handling code. I forget exactly.
I'd say let's just keep the tested parts here and drop the contextlib
part.
> 'import sys' should be done globally, not in the function.
Makes sense. If you can do both those tweaks and commit I'd appreciate
it!
Thanks for the review!
More information about the anaconda-patches
mailing list